Skip to content

[Backport to 16_0_X (#49860)] Refactor of PortableCollections #49953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 1 commit into from
Jan 30, 2026
Merged

[Backport to 16_0_X (#49860)] Refactor of PortableCollections #49953

cmsbuild merged 1 commit into from
Jan 30, 2026

Conversation

@Electricks94
Copy link
Contributor

@Electricks94 Electricks94 commented Jan 28, 2026 •
edited
Loading

The PortableCollections have an inconsistent interface if used with a normal Layout or with an SoABlocks Layout. In the later case, the Alpaka Queue is the first argument, while in the first case it is the other way around. This PR addresses the problem and sets the Alpaka Queue always as the first argument.

Furthermore, the constructors of the PortableCollections are streamlined to always use std::integal as the input type for the elements. Then a checked_cast has been implemented that checks if casting to int is safe. If so, the inputs are casted to int. Casting to int is necessary since the SoA Layouts use int for the number of elements due to the dependency on ROOT.

This PR has to be addressed after #49882.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #49860 to CMSSW_16_0_X

This PR also contains commits from #49882. It is meant to be merged after #49882 since it builds on top of it

ATTN @fwyzard

@felicepantaleo fyi

@cmsbuild cmsbuild added this to the CMSSW_16_0_X milestone Jan 28, 2026
@Electricks94
Copy link
Contributor Author

Electricks94 commented Jan 28, 2026

type ngt

@Electricks94
Copy link
Contributor Author

Electricks94 commented Jan 28, 2026

backport #49860

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 28, 2026 •
edited
Loading

A new Pull Request was created by @Electricks94 for CMSSW_16_0_X.

It involves the following packages:

  • CalibTracker/SiPixelESProducers (alca)
  • CondFormats/HcalObjects (alca, db)
  • DQM/SiPixelHeterogeneous (dqm)
  • DataFormats/HGCalDigi (simulation)
  • DataFormats/Portable (heterogeneous)
  • DataFormats/PortableTestObjects (heterogeneous)
  • DataFormats/SiPixelClusterSoA (heterogeneous, reconstruction)
  • DataFormats/SiPixelDigiSoA (heterogeneous, reconstruction)
  • DataFormats/SoATemplate (heterogeneous)
  • DataFormats/TrackSoA (heterogeneous, reconstruction)
  • DataFormats/TrackingRecHitSoA (heterogeneous, reconstruction)
  • DataFormats/VertexSoA (heterogeneous, reconstruction)
  • EventFilter/EcalRawToDigi (reconstruction)
  • EventFilter/HGCalRawToDigi (reconstruction)
  • EventFilter/HcalRawToDigi (reconstruction)
  • Geometry/HGCalMapping (geometry)
  • HeterogeneousCore/AlpakaTest (heterogeneous)
  • PhysicsTools/PyTorchAlpaka (heterogeneous, ml)
  • PhysicsTools/PyTorchAlpakaTest (heterogeneous, ml)
  • RecoHGCal/TICL (reconstruction)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalCalo/HGCalRecAlgos (reconstruction)
  • RecoLocalCalo/HGCalRecProducers (reconstruction)
  • RecoLocalCalo/HcalRecProducers (reconstruction)
  • RecoLocalTracker/Phase2TrackerRecHits (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoLocalTracker/SiStripClusterizer (reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • RecoParticleFlow/PFRecHitProducer (reconstruction)
  • RecoTauTag/HLTProducers (hlt)
  • RecoTracker/LST (reconstruction)
  • RecoTracker/LSTCore (reconstruction)
  • RecoTracker/PixelSeeding (reconstruction)
  • RecoTracker/PixelTrackFitting (reconstruction)
  • RecoVertex/PixelVertexFinding (reconstruction)

@Alejandro1400, @Dr15Jones, @JanChyczynski, @Martin-Grunewald, @Moanwar, @arunhep, @atpathak, @bsunanda, @civanch, @cmsbuild, @ctarricone, @francescobrivio, @fwyzard, @gabrielmscampos, @hjkwon260, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @perrotta, @rseidita, @srimanob, @valsdav, @y19y19 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @IzaakWN, @JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @VinInn, @VourMa, @abdoulline, @alesaggio, @apsallid, @argiro, @azotz, @bsunanda, @cseez, @denizsun, @dgulhan, @dkotlins, @echabert, @edjtscott, @elusian, @fabiocos, @felicepantaleo, @ferencek, @fioriNTU, @forthommel, @gbenelli, @gpetruc, @hatakeyamak, @idebruyn, @jandrea, @jlidrych, @lecriste, @lgray, @makortel, @mariadalfonso, @martinamalberti, @mbluj, @missirol, @mmarionncern, @mmasciov, @mmusich, @mroguljic, @mtosi, @pfs, @rchatter, @robervalwalsh, @rovere, @rsreds, @salimcerci, @sameasy, @seemasharmafnal, @sethzenz, @sobhatta, @thomreis, @threus, @tocheng, @tsusa, @vandreev11, @wang0jin, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 28, 2026 •
edited
Loading

cms-bot internal usage

@fwyzard
Copy link
Contributor

fwyzard commented Jan 28, 2026

please test

@fwyzard
Copy link
Contributor

fwyzard commented Jan 28, 2026

urgent

aimed at CMSSW_16_0_0

@mmusich
Copy link
Contributor

mmusich commented Jan 28, 2026

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 29, 2026

Pull request #49953 was updated. @Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @fwyzard, @hjkwon260, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @srimanob, @valsdav, @y19y19 can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Jan 29, 2026

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 29, 2026

+1

Size: This PR adds an extra 272KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0584d7/50984/summary.html
COMMIT: 2a5cc45
CMSSW: CMSSW_16_0_X_2026-01-28-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49953/50984/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4382508
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4382474
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 235 log files, 208 edm output root files, 55 DQM output files
  • TriggerResults: found differences in 1 / 53 workflows

@Moanwar
Copy link
Contributor

Moanwar commented Jan 29, 2026

+1

@fwyzard
Copy link
Contributor

fwyzard commented Jan 29, 2026

+heterogeneous

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Jan 30, 2026

+1

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Jan 30, 2026

merge

@cmsbuild cmsbuild merged commit 6c0910c into cms-sw:CMSSW_16_0_X Jan 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

alca-approved backport-ok db-approved geometry-pending heterogeneous-approved ml-pending ngt orp-approved pending-signatures reconstruction-approved tests-approved tracking trk urgent

Projects

None yet

Milestone

CMSSW_16_0_X

Development

Successfully merging this pull request may close these issues.

10 participants

@Electricks94 @cmsbuild @fwyzard @mmusich @Moanwar @perrotta @nothingface0 @ariostas @ftenchini @mandrenguyen